Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exec for the terraform command to avoid problem in SIGTERM #120

Merged
merged 3 commits into from
Jul 24, 2019
Merged

Use exec for the terraform command to avoid problem in SIGTERM #120

merged 3 commits into from
Jul 24, 2019

Conversation

pecigonzalo
Copy link
Contributor

@pecigonzalo pecigonzalo commented Jul 9, 2019

tfenv-exec is used by the terraform stub as exec but its not done on the tfenv-exec command, this causes that TERM and other signals land on bash instead of terraform which should not be the case and could lead to other problems as the "main" process is bash instead of terraform.
It should use exec to replace the bash process

@pecigonzalo
Copy link
Contributor Author

@Zordrak Any comments on this?

Copy link
Collaborator

@Zordrak Zordrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zordrak Zordrak merged commit c3f5d5e into tfutils:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants