Don't wait while pushing #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderpick
commented
Apr 14, 2020
| @@ -386,8 +383,6 @@ func (s *server) pushRecord(ctx context.Context, id thread.ID, lid peer.ID, rec | |||
| if err = s.ps.Publish(ctx, id, req); err != nil { | |||
| log.Errorf("error publishing record: %s", err) | |||
| } | |||
|
|
|||
| wg.Wait() | |||
There was a problem hiding this comment.
I can't remember why we waited here... probably out of an abundance of caution while developing.
| return err | ||
| } | ||
| if err = n.store.SetHead(id, lg.ID, r.Cid()); err != nil { | ||
| if err = n.bus.SendWithTimeout(NewRecord(r, id, lg.ID), notifyTimeout); err != nil { |
There was a problem hiding this comment.
Just flipping the order here. Seems safer to set the head before broadcasting.
| if err = n.PutRecord(ctx, id, lid, rec); err != nil { | ||
| return err | ||
| } | ||
| return n.server.pushRecord(ctx, id, lid, rec) |
There was a problem hiding this comment.
Surely this must have been a bug... why not push out records from AddRecord as well as CreateRecord?
There was a problem hiding this comment.
Yeah. Eventually, this can be different if we plan to batch pushes or similar, but not the case now.
SGTM.
sanderpick
force-pushed
the
sander/push-no-wait
branch
from
617d1cb
to
4195128
Compare
jsign
approved these changes
Apr 14, 2020
| if err = n.PutRecord(ctx, id, lid, rec); err != nil { | ||
| return err | ||
| } | ||
| return n.server.pushRecord(ctx, id, lid, rec) |
There was a problem hiding this comment.
Yeah. Eventually, this can be different if we plan to batch pushes or similar, but not the case now.
SGTM.
sanderpick
force-pushed
the
sander/push-no-wait
branch
from
4195128
to
3c95900
Compare
Signed-off-by: Sander Pick <[email protected]>
sanderpick
force-pushed
the
sander/push-no-wait
branch
from
3c95900
to
fb12fd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #309
Also pushes records added by
AddRecord.