Textile integration nits #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sanderpick
commented
Apr 11, 2020
sanderpick
commented
- Closes libp2p host key vs ACL #306
- Updates to Go 1.14.2
- Changes gRPC service names to be more explicit, which is less confusing in other services (textile)
Signed-off-by: Sander Pick <[email protected]>
sanderpick
requested review from
carsonfarmer
and removed request for
carsonfarmer
| @@ -1,5 +1,5 @@ | |||
| syntax = "proto3"; | |||
| package api.pb; | |||
| package threads.pb; | |||
There was a problem hiding this comment.
Will this have an impact on the exported Typescript/Javascript libraries?
| @@ -1,5 +1,5 @@ | |||
| syntax = "proto3"; | |||
| package net.api.pb; | |||
| package threads.net.pb; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.