Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread Delete #274

Merged
merged 4 commits into from
Mar 20, 2020
Merged

Thread Delete #274

merged 4 commits into from
Mar 20, 2020

Conversation

sanderpick
Copy link
Member

@sanderpick sanderpick commented Mar 19, 2020 •
edited
Loading

Closes #176

  • Adds ClearKeys and ClearLogKeys to KeyBook
  • Adds DeleteThread and DeleteLog to Logstore
  • Adds RemoveRecord and RemoveEvent in cbor
  • Implements DeleteThread in net

To-do:

  • Add DeleteThread to the net API and client
  • Figure out how to delete a DB from db.Manager

@sanderpick sanderpick self-assigned this Mar 19, 2020
@sanderpick sanderpick marked this pull request as ready for review March 19, 2020 22:25
jsign
jsign approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@jsign jsign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sanderpick sanderpick merged commit a0a95c6 into master Mar 20, 2020
@sanderpick sanderpick deleted the sander/thread-delete branch March 20, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsign jsign jsign approved these changes

@asutula asutula Awaiting requested review from asutula

Assignees

@sanderpick sanderpick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement thread delete
2 participants
@sanderpick @jsign