Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-start #260

Merged
merged 17 commits into from
Mar 17, 2020
Merged

Auto-start #260

merged 17 commits into from
Mar 17, 2020

Conversation

sanderpick
Copy link
Member

@sanderpick sanderpick commented Mar 10, 2020

Closes #267
Closes #230
Closes #264

  • Auto-starting stores via NewDB and NewDBFromAddr
  • Manager IDs are now thread.IDs
  • Consolidates gRPC services under a single server, which can be also be used in the same way under a single server in textile

Signed-off-by: Sander Pick <[email protected]>
@sanderpick sanderpick marked this pull request as ready for review March 13, 2020 04:41
Copy link
Member Author

@sanderpick sanderpick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for some 👀 !

db/db.go Outdated Show resolved Hide resolved
db/db.go Show resolved Hide resolved
db/dbthread.go Show resolved Hide resolved
db/manager.go Show resolved Hide resolved
db/manager.go Show resolved Hide resolved
service/service.go Show resolved Hide resolved
service/service.go Show resolved Hide resolved
service/service.go Show resolved Hide resolved
threadsd/main.go Show resolved Hide resolved
@sanderpick sanderpick self-assigned this Mar 13, 2020
@sanderpick
Copy link
Member Author

TODO: The Android client needs updating.

@asutula
Copy link
Member

asutula commented Mar 13, 2020

👀

Copy link
Member

@asutula asutula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking awesome, really good updates. Can't wait to get this merged into my folder sync tests branch and see what happens!

One thing that caught my eye... I noticed there were relatively few updates to the threads cli. I took a closer look and it appears the cli supports only a subset of the threads db api (unless I'm reading it wrong). What's the plan there?

I guess let's get the Android client up to date as well. Let me know if you need help with that.

api/client/client.go Outdated Show resolved Hide resolved
api/client/client.go Show resolved Hide resolved
api/client/client.go Show resolved Hide resolved
api/pb/api.proto Show resolved Hide resolved
api/service.go Show resolved Hide resolved
db/db.go Show resolved Hide resolved
examples/local_eventstore/books/main.go Show resolved Hide resolved
service/api/service.go Show resolved Hide resolved
service/service.go Show resolved Hide resolved
threadsd/main.go Show resolved Hide resolved
Copy link
Contributor

@jsign jsign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I left some comments with some questions!

cbor/event.go Outdated Show resolved Hide resolved
crypto/symmetric/symmetric.go Show resolved Hide resolved
db/collection.go Outdated Show resolved Hide resolved
db/db.go Outdated Show resolved Hide resolved
db/db.go Show resolved Hide resolved
db/dbthread.go Outdated Show resolved Hide resolved
db/manager.go Show resolved Hide resolved
@sanderpick
Copy link
Member Author

@asutula regarding the threads "shell", it will get replaced with the JS version that @eightysteele wrote: https://github.com/eightysteele/thread-shell

@sanderpick sanderpick merged commit 4a1769f into master Mar 17, 2020
@sanderpick sanderpick deleted the sander/auto-start branch March 17, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate gRPC servers Migrate manager keys to thread IDs Auto-start stores at creation time
3 participants