Use reflect api to improve find api, more tests #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Sutula <[email protected]>
sanderpick
approved these changes
Dec 5, 2019
api/client/read.go
Outdated
Comment on lines
89
to
102
| sliceType := reflect.TypeOf(dummySlice) | ||
| elementType := sliceType.Elem().Elem() | ||
| length := len(x.ModelFindReply.GetEntities()) | ||
| results := reflect.MakeSlice(sliceType, length, length) | ||
| for i, result := range x.ModelFindReply.GetEntities() { | ||
| target := reflect.New(elementType).Interface() | ||
| err := json.Unmarshal(result, target) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| val := results.Index(i) | ||
| val.Set(reflect.ValueOf(target)) | ||
| } | ||
| return results.Interface(), nil |
There was a problem hiding this comment.
Possible to make a reusable function?
There was a problem hiding this comment.
Yea of course. Good call.
Signed-off-by: Aaron Sutula <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to specify a dummy type when calling find and then use a simple type assertion when receiving the results.
This was a change we decided to make to help the create/save/find apis feel consistent.
closes #143