threads: temporary concurrency disabling #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jsign <[email protected]>
75a26b8
to
cd6abb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables most concurrency at the peer level. It attempts to achieve safety regarding data consistency.
All the editions have the same comments so to come back again to fix the edited points, which most probably will be soon.
In short, many
gostatements were removed. And at theservice.golayer, it leveragesthreadservicepullLocklock to serialize all threads interactions (quite extreme since is global lock per threadservice (which already existed for other thing, but is just temporal).After merging, I'll create a new repo with the underlying app that uncovered some of these things... so to keep it as a reference to be sure we solved this problem correctly.