Skip to content

Commit

Permalink
fix(pointer): support nested select (#888)
Browse files Browse the repository at this point in the history
Co-authored-by: Rob Caldecott <[email protected]>
  • Loading branch information
robcaldecott and Rob Caldecott committed Mar 31, 2022
1 parent a7f9906 commit e23e559
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/event/behavior/click.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {dispatchEvent} from '../dispatchEvent'
import {behavior} from './registry'

behavior.click = (event, target, config) => {
const context = target.closest('button,input,label,textarea')
const context = target.closest('button,input,label,select,textarea')
const control = context && isElementType(context, 'label') && context.control
if (control) {
return () => {
Expand Down
8 changes: 8 additions & 0 deletions tests/pointer/click.ts
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,14 @@ describe('label', () => {

expect(getEvents('click')).toHaveLength(2)
})

test('click nested select per label', async () => {
const {element, getEvents, user} = setup(`<label><select/></label>`)

await user.pointer({keys: '[MouseLeft]', target: element})

expect(getEvents('click')).toHaveLength(2)
})
})

describe('check/uncheck control per click', () => {
Expand Down

0 comments on commit e23e559

Please sign in to comment.