Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for queryFallback #518

Merged
merged 4 commits into from
Jul 4, 2020
Merged

Conversation

nickmccurdy
Copy link
Member

@nickmccurdy nickmccurdy commented Jul 3, 2020

It seems like #386 hasn't been fixed yet, so I added some information about queryFallbacks based on the dom-testing-library type and documentation text suggested in the issue. Feel free to suggest better wording/organization.

Preview: Scroll to the bottom of this section https://deploy-preview-518--testing-library.netlify.app/docs/dom-testing-library/api-queries#byrole

It seems like #386 hasn't been fixed yet.
@nickmccurdy nickmccurdy marked this pull request as ready for review July 3, 2020 09:22
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example with an element that has fallback roles might be helpful e.g. what does ByRole('switch' | 'checkbox', { queryFallbacks: true | false }) (all 4 combinations) return for <div role="switch checkbox" />?

@nickmccurdy nickmccurdy merged commit 5723d92 into master Jul 4, 2020
@nickmccurdy nickmccurdy deleted the nickmccurdy-patch-1 branch July 4, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants