Test Step HTML Viewer #50
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
Any chance you added the dep but didn't commit the yarn.lock file by any chance? |
|
Umm no, why? I'm not on my pc, but looks like there's a yarn.lock change in the second commit. |
febd997
to
63b93a5
Compare
63b93a5
to
239b784
Compare
|
@Bnaya PTAL too before I merge :] |
| } | ||
|
|
||
| export function HtmlViewer({ step: { mhtmlFile }, className: containerClass }: HtmlViewerProps) { | ||
| if (!mhtmlFile) { |
There was a problem hiding this comment.
We need this nicer empty state before we ship it
| return splitFiles[0]; | ||
| } | ||
|
|
||
| return async ({ params: { file } }, res) => { |
There was a problem hiding this comment.
flat async express middlewares are foot-gun
If one of the awaits will throw the request will hang,
we need additional wrapper here
| @@ -5739,6 +5747,11 @@ [email protected]: | |||
| resolved "https://registry.yarnpkg.com/bluebird-retry/-/bluebird-retry-0.11.0.tgz#1289ab22cbbc3a02587baad35595351dd0c1c047" | |||
| integrity sha1-EomrIsu8OgJYe6rTVZU1HdDBwEc= | |||
|
|
|||
| [email protected]: | |||
There was a problem hiding this comment.
Not blocking but we need to figure-out these exact deps on fast-mhtml side to avoid this duplication
| @@ -0,0 +1,60 @@ | |||
| import debug from 'debug'; | |||
| import { RequestHandler, Response } from 'express'; | |||
|
Great job! |
|
@benjamingr after another thought, this will not work for the cloud viewer. |
No description provided.