This repository has been archived by the owner on Sep 6, 2023. It is now read-only.
Contributors flow improvment #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Bnaya
commented
Sep 23, 2020
•
- More elaborated CONTRIBUTING.md
- Viewer ui files are now built when running root-cause cli on dev time
- overcome yarn not linking bins limitation by adding package.json scripts
Bnaya
commented
Sep 23, 2020
|
|
||
| if (!await fs.pathExists(path.resolve(DEV_STATIC_FILES_LOCATION, STATIC_INDEX_FILE))) { | ||
| console.log('Client Static files not found, building client project...'); | ||
| await buildClientStatics(); |
There was a problem hiding this comment.
Not sure what we should do on failure. for example, the user might have small lint error on the client code,
and not he won't be able to use the cli (all that in case he don't already have the statics)
Maybe we can just warn about it, and not fail.
benjamingr
reviewed
Sep 23, 2020
benjamingr
reviewed
Sep 23, 2020
benjamingr
reviewed
Sep 23, 2020
benjamingr
reviewed
Sep 23, 2020
benjamingr
reviewed
Sep 23, 2020
benjamingr
approved these changes
Sep 23, 2020
Co-authored-by: Benjamin Gruenbaum <[email protected]>
Co-authored-by: Benjamin Gruenbaum <[email protected]>
Co-authored-by: Benjamin Gruenbaum <[email protected]>
Co-authored-by: Benjamin Gruenbaum <[email protected]>
Co-authored-by: Benjamin Gruenbaum <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.