This repository has been archived by the owner on Sep 6, 2023. It is now read-only.
Welcome prettier #15
Merged
Welcome prettier #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c176d3
to
1c00a7c
Compare
benjamingr
reviewed
Sep 5, 2020
packages/tester/withHarRecord.ts
Outdated
| await new Promise((res) => { | ||
| setTimeout(res, 5000); | ||
| }); | ||
| // eslint-disable-next-line no-await-in-loop |
There was a problem hiding this comment.
Can we drop this eslint-rule while we are at it we know promises and the implications
1c00a7c
to
54d9a2a
Compare
54d9a2a
to
c04df38
Compare
b66e869
to
8499593
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.