Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom md5 remote path. #49

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

dmeulen
Copy link
Contributor

@dmeulen dmeulen commented Jun 3, 2024

We use the gitlab package registry to store ansible playbook releases. Gitlab has permalinks to the latest artifacts or to release assets. These links to artifacts or release assets are accessed using the gitlab API and my not be the actual path to the tarball or md5 checksum file.

A custom remote path for the link to the md5 hash would be very nice! This PR will add a http-checksum-url flag. If the http-checksum-url flag has not been set, it will use the http-url with .md5 added to the path.

Copy link
Contributor

@shk3 shk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit comment. Otherwise, looks good to me. I will give the approval once it's addressed.

Thanks for the contribution!

README.md Outdated Show resolved Hide resolved
Make clear a md5 hash is needed for http-checksum-url.
Copy link
Contributor

@shk3 shk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@shk3 shk3 merged commit a6da503 into teslamotors:master Jul 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants