JSXOpeningElement will not Stringify the name if first char is Uppercase #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a Switch for component naming in initReactNamespace -> _myTrait_.reactJSXOpeningElement. if the JSXIdentifier.name has an Uppercase Letter the name will not be stringify
|
Hi Lukas! Thank you for the changes! However, now that we have a new version 0.95 we could work on that. You can create a new branch to your local env from 0.95 without creating a new version. The idea would be to do something like "You in your local env": You can check that it is ok with The make changes there. After changes OK, do like The after you feel it's good create PR from that branch. |
|
Closing this, changes were moved to another branch and imported from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.