-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement floating "chat head" bubble #35
Conversation
* Add WindowControl toggles to minimize to bubble and exit (TODO need nice icons instead of ugly color placeholders)
* Move minimize button to left side and exit to far right
* Remove focus when displaying as bubble * Focus window if top control bar is tapped * Replace minimize button listener w/ expression lambda
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move drawable-anydpi-v26/round_button_with_outline.xml
to drawable/round_button_with_outline.xml
otherwise will cause missing resource crash on lower versions.
Also the float button requires clicking on the bottom right to open if minimized. Clicking on center does not work. If reproducible and fixable, then do it.
Thanks
* Ignore window control touch interception if window controls are not visible
Done
Tapping on center has worked for me on the 4 devices I've tested with.. I did find issue if you tap near very top it wasn't working, so I added a fix. Hopefully that will fix your issue as well. |
Clicking anywhere in the bubble to restore it to full size works for me as well. It is not possible to long press the top bar to resize or move the window, I have to press the terminal area. Not really a big problem, but the top menu bar feels like the intuitive place to press for moving or re-size a window |
Ya I encountered this as well. One idea I think would be useful is to add more controls to the remaining space (such as a hide/show/disable keyboard, settings, etc..) in future and keep this space reserved for those actions. That way touching an item doesn't accidentally cause a change to the terminal window. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working fine now. Unless new changes suggested by grimler needs to be added, this can be merged. Although, button to disable and/or hide keyboard, like in termux-app
could be more useful. I don't use the plugin myself, so up to others what suits their usability needs.
@dkramer95 Do you plan on adding anything else before I make a release? |
@agnostic-apollo There is a minor issue of bubble size on some display densities so I will be adding a fix to use |
Yeah definitely use I tried setting the default width and height to half the display size x/y, but that was throwing an exception due to Also check latest changes in For future, the most important thing would be to disable long press for changing size. This prevents copy/paste menu from showing. I disabled it myself which then started showing the selectors but for some reason the menu above them wouldn't show, I am not sure what's causing that, there are other touch listeners that might be causing it, didn't have time to look into it. The resizing option can be added to top level bar as a button, but preferable in a drop down so that more options can be added. |
Implement new bubble / "chat head" minimize functionality (#23)
Adds new top window controls panel w/ minimize and exit buttons:
Demo:
float-bubble-demo.mov