Alternative patch to fix fn-up fn-down pgup/pgdown #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in onKeyDown() return false when the key is not handled. The above two changes fix the handling of Fn-key combo's on devices with a physical keyboard, allowing the android system defined fallbacks from `/system/usr/keychars/Generic.kcm` to be properly handled. Fixes termux#731. Original diagnosis and fix by Konehaltia.
|
Thanks! This is now available in v0.65 of the app, which has been released and is rolling out as an update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The above two changes fix the handling of Fn-key combo's on devices with
a physical keyboard, allowing the android system defined fallbacks from
/system/usr/keychars/Generic.kcmto be properly handled.Fixes #731.
Original diagnosis and fix by Konehaltia.