Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated: Library, Gradle, NDK and Bootstrap updates #2875

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KitsunedFox
Copy link

Some users had some trouble with bootstrap packages, leading to apt failures, so i suggest keeping them updated.

Also i've included on this pull request some library, gradle and ndk updates.

@agnostic-apollo
Copy link
Member

agnostic-apollo commented Jul 11, 2022

The compileSdkVersion and (some) google library versions cannot be updated without requiring other changes. Check c59835ed9

Some users had some trouble with bootstrap packages, leading to apt failures

I assume you are referring to kcubeterm repo issue. Those are for v0.118.0 downloaded from F-Droid that's using bootstrap from january, issue wouldn't occur on bootstrap in master branch from april, although can be updated since its behind a couple of months now.

And follow contributing guidelines for commits.

https://github.com/termux/termux-app#for-maintainers-and-contributors

Gradle and ndk changes will need to be tested as well. Also the updated bootstrap on fresh installation and possibly compared against old version.

@KitsunedFox
Copy link
Author

KitsunedFox commented Jul 11, 2022

The compileSdkVersion and (some) google library versions cannot be updated without requiring other changes. Check c59835ed9

Some users had some trouble with bootstrap packages, leading to apt failures

I assume you are referring to kcubeterm repo issue. Those are for v0.118.0 downloaded from F-Droid that's using bootstrap from january, issue wouldn't occur on bootstrap in master branch from april, although can be updated since its behind a couple of months now.

And follow contributing guidelines for commits.

https://github.com/termux/termux-app#for-maintainers-and-contributors

Gradle and ndk changes will need to be tested as well. Also the updated bootstrap on fresh installation and possibly compared against old version.

i've already tested the updated libs on old and fresh installation, using termux-monet (my termux fork). Everything worked, even with compileSdkVersion 31. but i'm not sure if these changes would work on Android <12. that would need to be tested with older devices.

@KitsunedFox KitsunedFox changed the title Library and bootstrap updates Updated: Library and bootstrap updates Jul 12, 2022
@KitsunedFox
Copy link
Author

All the changes were successfully tested on Android 10, 9 and 7. Soon i'll test on Android 5

@KitsunedFox KitsunedFox force-pushed the termux-contributions branch 2 times, most recently from a96210a to fffd1c9 Compare July 27, 2022 12:55
@KitsunedFox KitsunedFox changed the title Updated: Library and bootstrap updates Updated: Library, Gradle, NDK and Bootstrap updates Jul 27, 2022
@KitsunedFox KitsunedFox force-pushed the termux-contributions branch 2 times, most recently from 4cdf3b7 to 65f7581 Compare July 27, 2022 13:25
@agnostic-apollo
Copy link
Member

Have you checked Jitpack and F-Droid incompatibility for bumping compileSdkVersion and fixes required?

@KitsunedFox
Copy link
Author

Have you checked Jitpack and F-Droid incompatibility for bumping compileSdkVersion and fixes required?

No fixed were required for bumping compileSdkVersion, and Jitpack workflow is successfully executed

And i've tested on Android 5 some minutes ago, everything works

@KitsunedFox
Copy link
Author

Have you checked Jitpack and F-Droid incompatibility for bumping compileSdkVersion and fixes required?

But i don't have access to termux's jitpack and f-droid admin accounts to deploy anything and test, only fork's workflows

@agnostic-apollo
Copy link
Member

Okay. Thanks. Will test myself and look into F-Droid as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants