Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes termux/termux-app#2415 #2538

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixes termux/termux-app#2415 #2538

wants to merge 1 commit into from

Conversation

Hax4us
Copy link
Member

@Hax4us Hax4us commented Jan 21, 2022

No description provided.

@agnostic-apollo
Copy link
Member

Thanks for this, will look into testing and merging after I push my local changes to master.

@babaric-dev
Copy link

Will this be merged? This is a very very useful thing that we miss now.

@agnostic-apollo
Copy link
Member

Not for next release. The changes in this pull (not branch) are broken.

@babaric-dev
Copy link

Then should I reimplement this with the up-to-date repo?

@agnostic-apollo
Copy link
Member

Like I said, current branch issues against master are not the issue, but the initial pull request changes submitted are, even though it was a clean code. There is a pretty big logical one too, should be noticeable to others too, one million imaginary dollar to whoever figures it out first... ;)

There also other issues as well regarding how this should ideally be implemented. Redoing with up-to-data master won't fix them. Fixing them all would be time consuming, time which I currently don't have since other higher priority things are being worked on, likely no time for testing either, unless someone else fixes them all as per quality and security standards required.

@PiprTuff
Copy link

May I hope to get this PR merged into master this year?

@agnostic-apollo
Copy link
Member

Possibly this year, but not for next release or next 1-2 months if I have to do it.

@PiprTuff
Copy link

Possibly this year, but not for next release or next 1-2 months if I have to do it.

Its been very long since I have been waiting for this issue to be solved. No idea what other maintainers are doing. 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants