fix: create safe-buffers

Replace the overloaded Buffer constructor with the safer alternative,
via the shim that makes it possible to support across our entire
supported range.

.travis.yml

@@ -12,4 +12,4 @@ matrix:
  - node_js: 10
  script: npm run lint
 script:
- - npm run test
+ - node --throw-deprecation ./node_modules/.bin/tape --require intelli-espower-loader test/*.js

lib/minify.js

@@ -1,4 +1,5 @@
 'use strict';
+var Buffer = require('safe-buffer').Buffer;
 var applySourceMap = require('vinyl-sourcemaps-apply');
 var isObject = require('lodash/fp/isObject');
 var defaultsDeep = require('lodash/fp/defaultsDeep');
@@ -64,7 +65,7 @@ module.exports = function(uglify, log) {
  });
  }
 
- file.contents = new Buffer(mangled.code);
+ file.contents = Buffer.from(mangled.code);
 
  if (hasSourceMaps) {
  var sourceMap = JSON.parse(mangled.map);

package.json

@@ -9,6 +9,7 @@
  "has-gulplog": "^0.1.0",
  "lodash": "^4.13.1",
  "make-error-cause": "^1.1.1",
+ "safe-buffer": "^5.1.2",
  "through2": "^2.0.0",
  "uglify-js": "^3.0.5",
  "vinyl-sourcemaps-apply": "^0.2.0"

test/create-error.js

@@ -1,6 +1,7 @@
 'use strict';
 var test = require('tape-catch');
 var assert = require('assert');
+var Buffer = require('safe-buffer').Buffer;
 var Vinyl = require('vinyl');
 var createError = require('../lib/create-error');
 var GulpUglifyError = require('../lib/gulp-uglify-error');
@@ -44,6 +45,6 @@ function createTestFile() {
  cwd: '/home/terin/broken-promises/',
  base: '/home/terin/broken-promises/test',
  path: '/home/terin/broken-promises/test/test2.js',
- contents: new Buffer(testOkContentsInput)
+ contents: Buffer.from(testOkContentsInput)
  });
 }

test/err.js

@@ -1,6 +1,7 @@
 'use strict';
 var test = require('tape');
 var assert = require('assert');
+var Buffer = require('safe-buffer').Buffer;
 var Vinyl = require('vinyl');
 var td = require('testdouble');
 var GulpUglifyError = require('../lib/gulp-uglify-error');
@@ -11,7 +12,7 @@ test('errors should report files in error', function(t) {
  cwd: '/home/terin/broken-promises/',
  base: '/home/terin/broken-promises/test',
  path: '/home/terin/broken-promises/test/test1.js',
- contents: new Buffer('function errorFunction(error)\n{')
+ contents: Buffer.from('function errorFunction(error)\n{')
  });
  var uglify = td.object(['minify']);
  var logger = td.object(['warn']);
@@ -68,7 +69,7 @@ test("errors shouldn't blow up", function(t) {
  cwd: '/home/terin/broken-promises/',
  base: '/home/terin/broken-promises/test',
  path: '/home/terin/broken-promises/test/test1.js',
- contents: new Buffer('{}')
+ contents: Buffer.from('{}')
  });
  var uglify = td.object(['minify']);
  var logger = td.object(['warn']);

test/minify.js

@@ -2,6 +2,7 @@
 var test = require('tape');
 var assert = require('assert');
 var Vinyl = require('vinyl');
+var Buffer = require('safe-buffer').Buffer;
 var td = require('testdouble');
 var minify = require('../lib/minify');
 
@@ -78,6 +79,6 @@ function createTestFile(input) {
  cwd: '/home/terin/broken-promises/',
  base: '/home/terin/broken-promises/test',
  path: '/home/terin/broken-promises/test/test1.js',
- contents: new Buffer(input)
+ contents: Buffer.from(input)
  });
 }

test/sourcemap.js

@@ -1,6 +1,7 @@
 'use strict';
 var test = require('tape');
 var assert = require('assert');
+var Buffer = require('safe-buffer').Buffer;
 var Vinyl = require('vinyl');
 var SourceListMap = require('source-list-map').SourceListMap;
 var fromStringWithSourceMap = require('source-list-map')
@@ -15,7 +16,7 @@ test('sourcemaps should be merged', function(t) {
  cwd: '/home/terin/broken-promises/',
  base: '/home/terin/broken-promises/test',
  path: '/home/terin/broken-promises/test/test1.js',
- contents: new Buffer(testContents1Input)
+ contents: Buffer.from(testContents1Input)
  });
 
  var originalMap = new SourceListMap();
@@ -80,7 +81,7 @@ test('sourcemaps should merge when concatted', function(t) {
  cwd: '/home/terin/broken-promises/',
  base: '/home/terin/broken-promises/test',
  path: '/home/terin/broken-promises/test/test1.js',
- contents: new Buffer(String(inMap))
+ contents: Buffer.from(String(inMap))
  });
  testFile.sourceMap = inMap.toStringWithSourceMap({file: 'test1.js'}).map;