Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(embed): handle snippet not found #53

Merged
merged 6 commits into from
Oct 17, 2022
Merged

feat(embed): handle snippet not found #53

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5913b9b
chore(embed): setup tests
tericcabrel Oct 12, 2022
a069561
feat(embed): render html content for snippet not found
tericcabrel Oct 13, 2022
a42ac1e
test(embed): write unit tests for embed generator utility functions
tericcabrel Oct 14, 2022
e72fd91
feat(embed): handle snippet not found
tericcabrel Oct 17, 2022
88528e8
fix: failing tests
tericcabrel Oct 17, 2022
6526976
feat(embed): publish the package on npm
tericcabrel Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
feat(embed): publish the package on npm
  • Loading branch information
@tericcabrel
tericcabrel committed Oct 17, 2022
commit 6526976d7a40b7339d2cc0e02f6525828a422ecb
6 changes: 1 addition & 5 deletions .github/workflows/publish-embed.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,7 @@ on:
paths:
- 'packages/embed/src/scripts/**'
- 'packages/embed/src/styles/**'
pull_request:
branches: [ main ]
paths:
- 'packages/embed/src/scripts/**'
- 'packages/embed/src/styles/**'

jobs:
build:
runs-on: ubuntu-latest
Expand Down