Support multi-dimensional output for CP regression #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
==========================================
+ Coverage 87.16% 87.23% +0.06%
==========================================
Files 125 125
Lines 7876 7910 +34
==========================================
+ Hits 6865 6900 +35
+ Misses 1011 1010 -1 ☔ View full report in Codecov by Sentry. |
|
I will add new test cases for multi-dimensional outputs🙂 |
aarmey
requested changes
Jan 31, 2023
There was a problem hiding this comment.
This looks great @merajhashemi! Could you please run black formatting on the code? black tensorly in the top directory should do it.
|
@merajhashemi if you have the time would be great to actually get this merged! :) |
This reverts commit 2dcee40.
# Conflicts: # tensorly/regression/cp_regression.py
|
@JeanKossaifi I'm not sure what was left from this PR. The tests were passing; I just had to update the code style. I think it's ready to be merged 😄 |
|
Thanks @merajhashemi! Merging. |
|
Fabulous, thank you @merajhashemi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr resolves #51 (CP only).