Add data to union package and bump version to 0.14.0

[kangyizhang]

Add [email protected] into union package.

Please notice that data api is exported as tf.data

Description

---

For repository owners only:

Please remember to apply all applicable tags to your pull request.
Tags: FEATURE, BREAKING, BUG, PERF, DEV, DOC, SECURITY

For more info see: https://github.com/tensorflow/tfjs/blob/master/DEVELOPMENT.md

---

This change is 

[davidsoergel]

Reviewed 7 of 7 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @nsthorat, @davidsoergel, and @dsmilkov)

[dsmilkov]

Awesome. Couple comments

Reviewed 6 of 7 files at r1.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @kangyizhang, @nsthorat, and @dsmilkov)

---

package.json, line 64 at r1 (raw file):

    "@tensorflow/tfjs-converter": "0.6.7",
    "@tensorflow/tfjs-core": "0.13.11",
    "@tensorflow/tfjs-data": "0.1.1",

tfjs-data should depend on core 0.13.11 to avoid the warning about invalid peer dep when installing tfjs. This means you'll have to release a new tfjs-data, but should be quick.

---

rollup.config.js, line 50 at r1 (raw file):

      // Polyfill require() from dependencies.
      commonjs({
        ignore: ['crypto', 'node-fetch'],

Do you need node-fetch and utf8.js changes to make rollup happy? (curious if that's resolved now that there is a "module" field in tfjs-data's package.json which points to an esm bundle that already ignores that.

---

yarn.lock, line 89 at r1 (raw file):

    "@types/webgl2" "0.0.4"
    seedrandom "2.4.3"

I think the large change in yarn.lock is probably due to the fact that you had to delete yarn.lock on your computer. Given that exploits that happened recently in npm, let's try to make lock files change less. Can you checkout the yarn.lock from master and re-do yarn install and see if you get less changes?

[nsthorat]

Question for folks, @kangyizhang, @dsmilkov: we've been informally keeping the union version in sync with the core version, maybe we should release a minor of core?

[dsmilkov]

Sounds good - ping this thread when you release 0.14 in core.

[kangyizhang]

Sounds good. I'll release new tfjs-data depending on [email protected] and then update this PR.

[kangyizhang]

Reviewable status: complete! 1 of 1 approvals obtained (waiting on @dsmilkov and @nsthorat)

---

package.json, line 64 at r1 (raw file):

Previously, dsmilkov (Daniel Smilkov) wrote…

tfjs-data should depend on core 0.13.11 to avoid the warning about invalid peer dep when installing tfjs. This means you'll have to release a new tfjs-data, but should be quick.

As discussed, a release of tfjs-data depending on [email protected] will be pushed once core is released.

---

rollup.config.js, line 50 at r1 (raw file):

Previously, dsmilkov (Daniel Smilkov) wrote…

Do you need node-fetch and utf8.js changes to make rollup happy? (curious if that's resolved now that there is a "module" field in tfjs-data's package.json which points to an esm bundle that already ignores that.

node-fetch is not required in this ignore field. but required in output otherwise the generated tf.js and tf.min.js can not be used.

---

yarn.lock, line 89 at r1 (raw file):

Previously, dsmilkov (Daniel Smilkov) wrote…

I think the large change in yarn.lock is probably due to the fact that you had to delete yarn.lock on your computer. Given that exploits that happened recently in npm, let's try to make lock files change less. Can you checkout the yarn.lock from master and re-do yarn install and see if you get less changes?

Will update yarn once [email protected] is released.

[nsthorat]

Released:

• tfjs-core 0.14.0
• tfjs-layers 0.9.0
• tfjs-converter 0.7.0

[nsthorat]

Reviewable status: complete! 1 of 1 approvals obtained (waiting on @dsmilkov, @kangyizhang, and @nsthorat)

---

package.json, line 59 at r3 (raw file):

  },
  "dependencies": {
    "@tensorflow/tfjs-converter": "0.6.7",

reminder to update these