Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update union to alpha3 #1245

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Update union to alpha3 #1245

merged 1 commit into from
Feb 14, 2019

Conversation

dsmilkov
Copy link
Contributor

@dsmilkov dsmilkov commented Feb 14, 2019

This change is Reviewable

@dsmilkov dsmilkov changed the title Update union to alpha4 Update union to alpha3 Feb 14, 2019
Copy link
Contributor

@tafsiri tafsiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @caisq and @tafsiri)

Copy link
Contributor

@tafsiri tafsiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @caisq and @dsmilkov)


package.json, line 59 at r1 (raw file):

  },
  "dependencies": {
    "@tensorflow/tfjs-converter": "1.0.0-alpha4",

Just confirming that alpha4 is what you want and not alpha3.

Copy link
Contributor Author

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @caisq and @tafsiri)


package.json, line 59 at r1 (raw file):

Previously, tafsiri (Yannick Assogba) wrote…

Just confirming that alpha4 is what you want and not alpha3.

Yes, originally planned to be alpha3, but I found a bug in the converter last night.

Copy link
Contributor

@tafsiri tafsiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @caisq)

@dsmilkov dsmilkov merged commit 3029de0 into master Feb 14, 2019
@dsmilkov dsmilkov deleted the version branch February 14, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants