Skip to content
This repository has been archived by the owner on Aug 15, 2019. It is now read-only.

Move core to its own folder and enable Monorepo Build #1876

Merged
merged 21 commits into from
Aug 12, 2019
Merged

Conversation

dsmilkov
Copy link
Contributor

@dsmilkov dsmilkov commented Aug 12, 2019

Move core to its own folder tfjs-core and enable Monorepo build system where each package build runs only if the PR touches a file in that package folder.


This change is Reviewable

@dsmilkov dsmilkov changed the title WIP move core to its own folder Move core to its own folder and enable Monorepo Build Aug 12, 2019
@dsmilkov dsmilkov requested a review from nsthorat August 12, 2019 20:20
Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 41 of 369 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov and @nsthorat)


package.json, line 6 at r1 (raw file):

    "rimraf": "~2.6.2",
    "shelljs": "~0.8.3",
    "ts-node": "~7.0.0",

I think you dont need this

Copy link
Contributor Author

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained


package.json, line 6 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

I think you dont need this

Removed.

@dsmilkov dsmilkov merged commit 8c2d9e0 into master Aug 12, 2019
@dsmilkov dsmilkov deleted the move-core branch August 12, 2019 20:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants