Skip to content
This repository has been archived by the owner on Aug 15, 2019. It is now read-only.

Cleanup intopk to remove it as a kernel. #1873

Merged
merged 6 commits into from
Aug 8, 2019
Merged

Cleanup intopk to remove it as a kernel. #1873

merged 6 commits into from
Aug 8, 2019

Conversation

nsthorat
Copy link
Contributor

@nsthorat nsthorat commented Aug 8, 2019

This PR:

  • Removes the kernel intopk because we don't support async kernels
  • Renames inTopK to inTopKAsync
  • Changes unit tests to support the async error throwing expectations.

This change is Reviewable

@nsthorat nsthorat requested a review from dsmilkov August 8, 2019 13:54
Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 9 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov and @nsthorat)


src/ops/in_top_k.ts, line 3 at r1 (raw file):

/**
 * @license
 * Copyright 2018 Google LLC. All Rights Reserved.

2019


src/ops/in_top_k.ts, line 25 at r1 (raw file):

/**
 * Says whether the targets are in the top K predictions.

Returns


src/ops/in_top_k.ts, line 30 at r1 (raw file):

 * const predictions = tf.tensor2d([[20, 10, 40, 30], [30, 50, -20, 10]]);
 * const targets = tf.tensor1d([2, 0]);
 * const precision = tf.inTopK(predictions, targets);

fix the snippet

@nsthorat nsthorat merged commit b484b28 into master Aug 8, 2019
@nsthorat nsthorat deleted the intopk branch August 8, 2019 18:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants