Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix newline issue with sed on macOS #6563

Merged
merged 2 commits into from
Jun 26, 2019
Merged

Fix newline issue with sed on macOS #6563

merged 2 commits into from
Jun 26, 2019

Conversation

aysark
Copy link
Contributor

@aysark aysark commented Apr 11, 2019

Addresses #5033.

There was a PR for this previously but user didn't agree to cla it seems #5115

Copy link

@knumat knumat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this fix on macOS Mojave 10.14.5 and it worked for me. (I had been having the exact issue as was described in #5033 ). Thanks for publishing this!

Hopefully someone will merge this now...

@aysark
Copy link
Contributor Author

aysark commented Jun 3, 2019

@pkulzc @jch1 @derekjchow @dreamdragon can you review?

@pkulzc
Copy link
Contributor

pkulzc commented Jun 26, 2019

Sorry for the late response as most of us are traveling for some conferences recently.

@pkulzc pkulzc merged commit fcdb876 into tensorflow:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants