Points default data_dir to child folder. #6131
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now if you run the README as-is it will work. I made the default data_dir go deeper into the directory structure. If a user does their own --data_dir there will still be a mismatch but this will improve the situation for anyone just running the command which I believe is the most normal.
The final fix would be to have download_and_extract move the data up a folder.
This problem was created to fix tests in borg where the cifar-10 dataset is not nested under
cifar-10-batches-bin
. Maybe that was a mistake, I don't think so but... shrug...open to opinion.