adding implementation of https://arxiv.org/abs/1805.06066 #5265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @arsalan-mousavian. Typically, models in the Research repository require a collaborator at Google Research to take ownership. Are you working with someone there, or do you have somebody who is willing to act as reviewer and owner of the code? |
|
Lovely. Thanks for letting me know. |
ayzaan
approved these changes
Sep 7, 2018
| ### TODO: SUNCG Dataset | ||
| Current version of the code does not support SUNCG dataset. It can be added by | ||
| implementing necessary functions of `envs/task_env.py` using the public | ||
| releaseed code of SUNCG environment such as |
| ## 3. Training | ||
| Right now, the released version only supports training and inference using the real data from Active Vision Dataset. | ||
|
|
||
| When RGB image modality is used Resnet the embedding is initialized is used To start the training download pre-trained Resnet50 check point in the working directory ./resnet_v2_50_checkpoint/resnet_v2_50.ckpt |
There was a problem hiding this comment.
seems like a typo here.
Maybe something like:
When the RGB image modality is used, the Resnet embeddings are initialized.
|
Addressed the comments. Please take a look. |
robieta
approved these changes
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.