Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dwarf 5 fixes #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Dwarf 5 fixes #5

wants to merge 2 commits into from

Conversation

jhawthorn
Copy link

@jhawthorn jhawthorn commented Mar 1, 2022

Fixes a few issues I'm running into under arch linux+gcc

  • DW_FORM_implicit_const is immediately followed by a signed LEB128 value, which was causing tags to be read incorrectly
  • DW_FORM_line_strp is similar to DW_FORM_strp but it reads from the .debug_line_str section instead of .debug_str
    • I haven't implemented the actual reading yet. It might be helpful to pass around some sort of file adapter object rather than individual sections Solved by passing multiple sections to name

DW_FORM_implicit_const takes a signed LEB128 immediately following the
form.
@jhawthorn jhawthorn marked this pull request as ready for review March 5, 2022 19:11
Copy link
Owner

@tenderlove tenderlove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Happy to merge if you are done with this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants