Fix TestWorkflowTaskRedirectInRetryFirstTask flake #6189
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
v1.1
to land in visibility before validating entire build id search attribute structure (this solves the observed flake)v1.2
before validating it (not sure if this would flake, but it could)Why?
Here's a run with the latest flake: https://github.com/temporalio/temporal/actions/runs/9575636250/job/26400905169
We need to make sure that the build ID search attribute has enough time to update before we validate all the parts of it.
How did you test it?
Tested locally, testing in CI now
Potential risks
None
Documentation
Commented function
Is hotfix candidate?
No