Check for breaking proto changes #6114
Conversation
develop/buf-breaking.sh
Outdated
| check_against_commit HEAD^ "parent" | ||
|
|
||
| # Next check against main: | ||
| git -C "$tmp" fetch https://github.com/temporalio/temporal.git main |
There was a problem hiding this comment.
Do we want to tell git to do a shallow/single-branch fetch here?
--depth 1 --single-branch
There was a problem hiding this comment.
Only --depth=1 applies to fetch. I think in general I think the commit this is running on will be pretty close to main so I doubt it makes much difference but might as well.
|
I removed the buf upgrade from this PR. I couldn't get buf 1.32.2 to respect a config file (to change the compatibility level and add ignores) when using binpb inputs after trying many many combinations of flags and things. buf 1.6.0 respects the config file 🤷 |
| @@ -0,0 +1,50 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
There was a problem hiding this comment.
It might be helpful to add a short comment at the top to summarize what the script is for. It took me a while to wrap me head around what was going on here.
I filed a bug against buf and they fixed it. It'll probably be in buf 1.35.0. After that we can upgrade buf to use v2 configs if desired (but no rush) |
dnr
force-pushed
the
breaking
branch
4 times, most recently
from
e017bb0
to
ae24fd3
Compare
|
I think this PR is broken.. GH is no longer running tests on push. Going to close/reopen to see if that fixes it |
|
Still not running tests, going to try with a new PR |
dnr
force-pushed
the
breaking
branch
3 times, most recently
from
63fc8b0
to
ee5ad98
Compare
What changed?
Why?
Detecting breaking proto changes early avoids bugs.
How did you test it?
Manual testing with deliberate breaking changes.