Use stdlib slices #6018
Open
Use stdlib slices #6018
+38
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alexshtin
approved these changes
May 29, 2024
alexshtin
reviewed
May 29, 2024
bgerrity
force-pushed
the
brendan.gerrity/use-stdlib-slices
branch
from
bf15005
to
fd3182e
Compare
bgerrity
force-pushed
the
brendan.gerrity/use-stdlib-slices
branch
from
fd3182e
to
bc38cdb
Compare
|
@alexshtin I think CI needs a kick to run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Switched references from
golang.org/x/exp/slicesto the standard library package.Why?
The stdlib
slicespackage was introduced in Go 1.21 so can use it. The signature changes in #4706 was all the real lifting.How did you test it?
Ran unit tests locally. CI for the rest.
Potential risks
None.
Documentation
n/a
Is hotfix candidate?
No.