Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove awk dependency in auto-setup.sh #2068

Merged
merged 4 commits into from
Oct 19, 2021

Conversation

alexshtin
Copy link
Member

@alexshtin alexshtin commented Oct 18, 2021

What changed?
Remove awk dependency in auto-setup.sh.

Why?
Replace it with simple {VARNAME%%,*}: https://www.gnu.org/software/bash/manual/html_node/Shell-Parameter-Expansion.html.

How did you test it?
Build image locally and run it using docker-compose.

Potential risks
No risks.

Is hotfix candidate?
No.

@alexshtin alexshtin requested review from a team and dnr October 18, 2021 22:16
docker/auto-setup.sh Outdated Show resolved Hide resolved
docker/auto-setup.sh Outdated Show resolved Hide resolved
@alexshtin alexshtin enabled auto-merge (squash) October 18, 2021 23:17
@yiminc yiminc disabled auto-merge October 18, 2021 23:18
@yiminc yiminc enabled auto-merge (squash) October 18, 2021 23:19
@yiminc yiminc merged commit 077d39c into temporalio:master Oct 19, 2021
@alexshtin alexshtin deleted the feature/remove-awk branch October 29, 2021 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants