Add additional validation to decodeInfoLine #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…contain EXTINF:-1 and nothing else
|
Master is really really dead at this point, so it should really be against dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decodeInfoLine will crash if "EXTINF:-1" is found but the m3u is split into multiple lines.
This should skip records that only have "EXTINF:-1" and nothing else (which would be useless anyway).
So this does not fix the issue of having a record split into multiple lines but does prevent it from crashing the application.
I wasn't sure if this should be branched of master or dev. Let me know if I should re-submit the fix for dev if you find this fix acceptable.