Generic fallback for logdet (with numbers in mind) (JuliaLang#22629)

tekverkp · Jul 7, 2017 · ad9f5de · ad9f5de
1 parent 3a5d19a
commit ad9f5de
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/base/linalg/generic.jl b/base/linalg/generic.jl
@@ -1261,6 +1261,8 @@ function logdet(A::AbstractMatrix)
  return d + log(s)
 end
 
+logdet(A) = log(det(A))
+
 const NumberArray{T<:Number} = AbstractArray{T}
 
 """

diff --git a/test/linalg/generic.jl b/test/linalg/generic.jl
@@ -48,6 +48,7 @@ for elty in (Int, Rational{BigInt}, Float32, Float64, BigFloat, Complex{Float32}
 
  debug && println("element type: $elty")
 
+ @test logdet(A[1,1]) == log(det(A[1,1]))
  @test logdet(A) ≈ log(det(A))
  @test logabsdet(A)[1] ≈ log(abs(det(A)))
  @test logabsdet(convert(Matrix{elty}, -eye(n)))[2] == -1