make fuzzy scoring more robust against whitespaces (JuliaLang#39932)

tekverkp · Apr 3, 2021 · 8d1f052 · 8d1f052
1 parent 78b629f
commit 8d1f052
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/stdlib/REPL/src/docview.jl b/stdlib/REPL/src/docview.jl
@@ -550,8 +550,10 @@ function matchinds(needle, haystack; acronym::Bool = false)
  is = Int[]
  lastc = '\0'
  for (i, char) in enumerate(haystack)
+ while !isempty(chars) && isspace(first(chars))
+ popfirst!(chars) # skip spaces
+ end
  isempty(chars) && break
- while chars[1] == ' ' popfirst!(chars) end # skip spaces
  if lowercase(char) == lowercase(chars[1]) &&
  (!acronym || !isletter(lastc))
  push!(is, i)

diff --git a/stdlib/REPL/test/docview.jl b/stdlib/REPL/test/docview.jl
@@ -41,3 +41,9 @@ end
  # https://github.com/JuliaLang/julia/issues/37757
  @test REPL.insert_hlines(IOBuffer(), nothing) === nothing
 end
+
+@testset "fuzzy score" begin
+ # https://github.com/JunoLab/FuzzyCompletions.jl/issues/7
+ # shouldn't throw when there is a space in a middle of query
+ @test (REPL.matchinds("a ", "a file.txt"); true)
+end