add misc touch-ups to IOBuffer (JuliaLang#25919)

tekverkp · Feb 7, 2018 · 2ca63e1 · 2ca63e1
1 parent e879820
commit 2ca63e1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -746,6 +746,10 @@ Deprecated or removed
 
  * The unexported type `AbstractIOBuffer` has been renamed to `GenericIOBuffer` ([#17360] [#22796]).
 
+ * `IOBuffer(data::AbstractVector{UInt8}, read::Bool, write::Bool, maxsize::Integer)`,
+ `IOBuffer(read::Bool, write::Bool)`, and `IOBuffer(maxsize::Integer)` are
+ deprecated in favor of constructors taking keyword arguments ([#25872]).
+
  * `Display` has been renamed to `AbstractDisplay` ([#24831]).
 
  * Remaining vectorized methods over `SparseVector`s, particularly `floor`, `ceil`,

diff --git a/base/iobuffer.jl b/base/iobuffer.jl
@@ -53,7 +53,7 @@ julia> write(io, "JuliaLang is a GitHub organization.", " It has many members.")
 julia> String(take!(io))
 "JuliaLang is a GitHub organization. It has many members."
 
-julia> io = IOBuffer("JuliaLang is a GitHub organization.")
+julia> io = IOBuffer(b"JuliaLang is a GitHub organization.")
 IOBuffer(data=UInt8[...], readable=true, writable=false, seekable=true, append=false, size=35, maxsize=Inf, ptr=1, mark=-1)
 
 julia> read(io, String)
@@ -70,6 +70,12 @@ julia> write(io, "JuliaLang is a GitHub organization.")
 
 julia> String(take!(io))
 "JuliaLang is a GitHub organization"
+
+julia> length(read(IOBuffer(b"data", read=true, truncate=false)))
+4
+
+julia> length(read(IOBuffer(b"data", read=true, truncate=true)))
+0
 ```
 """
 function IOBuffer(
@@ -106,9 +112,6 @@ function IOBuffer(;
  truncate=flags.truncate,
  maxsize=maxsize)
  buf.data[:] = 0
- if flags.truncate
- buf.size = 0
- end
  return buf
 end