Reject Symmetric(Hermitian(A)) if diagonal of A is not real, fixes J…

…uliaLang#30814. (JuliaLang#31051)
tekverkp · Mar 7, 2019 · 05ee672 · 05ee672
1 parent ac8c5b7
commit 05ee672
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/stdlib/LinearAlgebra/src/symmetric.jl b/stdlib/LinearAlgebra/src/symmetric.jl
@@ -162,9 +162,14 @@ for (S, H) in ((:Symmetric, :Hermitian), (:Hermitian, :Symmetric))
  throw(ArgumentError("Cannot construct $($S); uplo doesn't match"))
  end
  end
- $S(A::$H) = $S(A.data, sym_uplo(A.uplo))
+ $S(A::$H) = $S(A, sym_uplo(A.uplo))
  function $S(A::$H, uplo::Symbol)
  if A.uplo == char_uplo(uplo)
+ if $H === Hermitian && !(eltype(A) <: Real) &&
+ any(!isreal, A.data[i] for i in diagind(A.data))
+
+ throw(ArgumentError("Cannot construct $($S)($($H))); diagonal contains complex values"))
+ end
  return $S(A.data, sym_uplo(A.uplo))
  else
  throw(ArgumentError("Cannot construct $($S); uplo doesn't match"))

diff --git a/stdlib/LinearAlgebra/test/symmetric.jl b/stdlib/LinearAlgebra/test/symmetric.jl
@@ -584,4 +584,12 @@ end
  @test (A / x)::Matrix == Matrix(A) / x
 end
 
+@testset "issue #30814: Symmetric of Hermitian if diag is not real" begin
+ A = [1 2; 3 4] * (1 + im)
+ B = Hermitian(A)
+ @test_throws ArgumentError Symmetric(B) == Symmetric(Matrix(B))
+ A[1,1] = 1; A[2,2] = 4
+ @test Symmetric(B) == Symmetric(Matrix(B))
+end
+
 end # module TestSymmetric