Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD/#3] pr checker 추가 #4

Merged
merged 6 commits into from
Jul 4, 2024
Merged

[ADD/#3] pr checker 추가 #4

merged 6 commits into from
Jul 4, 2024

Conversation

leeeyubin
Copy link
Member

@leeeyubin leeeyubin commented Jul 4, 2024

⛳️ Work Description

  • pr_checker.yml 추가
  • secrets 에 BASE_URL 추가
  • 그 외 자잘한 수정들

📢 To Reviewers

로컬프로퍼티 base.url로 수정해주세요~!

@leeeyubin leeeyubin added ADD ➕ 부수적인 코드 추가 및 라이브러리 추가, 새로운 파일 생성 유빈💙 유빈 labels Jul 4, 2024
@leeeyubin leeeyubin added this to the 프로젝트 초기 세팅 milestone Jul 4, 2024
@leeeyubin leeeyubin self-assigned this Jul 4, 2024
Copy link
Contributor

@arinming arinming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피알체커 안써봤는데 신기해요 ㅎㅎ 감사합니당 💚

@@ -29,8 +29,8 @@ android {
debug {
buildConfigField(
"String",
"OPEN_BASE_URL",
gradleLocalProperties(rootDir, providers).getProperty("open.base.url")
"BASE_URL",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base.url 변경 확인했슴둥.!

Copy link
Member

@boiledEgg-s boiledEgg-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr checker... 처음 보는 친구네요ㄷㄷ
당장 알아보러 가야겠습니다!!

Copy link
Contributor

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호 최고에욤❤️

@leeeyubin leeeyubin merged commit 16e746f into develop Jul 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADD ➕ 부수적인 코드 추가 및 라이브러리 추가, 새로운 파일 생성 유빈💙 유빈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADD] PR Checker 추가
4 participants