[ADD/#1] 프로젝트 초기 세팅 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boiledEgg-s
approved these changes
Jun 30, 2024
app/build.gradle.kts
Outdated
| alias(libs.plugins.kotlin.android) | ||
| alias(libs.plugins.hilt) | ||
| id("kotlin-parcelize") | ||
| id("kotlin-kapt") |
There was a problem hiding this comment.
이 부분은 ksp로 바꾸는 걸 고려해봐도 될 것 같아요!
ksp가 코틀린 기반이라 컴파일 시 더 효율적이라고 하네요
There was a problem hiding this comment.
예리한 석준씨,, 바꾸겠다 생각만 해놓고 까먹었네요🥲 수정했습니당!!
Comment on lines
+44
to
+51
| fun toMockEntity(): List<MockResponseModel> = data.map { | ||
| MockResponseModel( | ||
| avatar = it.avatar, | ||
| email = it.email, | ||
| firstName = it.first_name, | ||
| lastName = it.last_name | ||
| ) | ||
| } |
Comment on lines
+26
to
+34
| Scaffold( | ||
| bottomBar = { | ||
| MainBottomBar( | ||
| isVisible = navigator.showBottomBar(), | ||
| tabs = MainTab.entries.toList(), | ||
| currentTab = navigator.currentTab, | ||
| onTabSelected = navigator::navigate | ||
| ) | ||
| }, |
There was a problem hiding this comment.
지금 세팅이 이 컴포저블에서만 바텀바를 관리하는거죠??
화면마다 바텀바에에 포함된 컴포저블의 route와 비교해서 있으면 바텀바를 보여주고 없으면 보여주지 않는 로직이 맞나요?
There was a problem hiding this comment.
맞습니다! 바텀바가 있어야 하는 화면은 MainTabRoute로, 바텀바가 없어야 하는 화면은 Route로 관리해주면 될 것 같아요!
arinming
approved these changes
Jul 1, 2024
Comment on lines
+26
to
+34
| Scaffold( | ||
| bottomBar = { | ||
| MainBottomBar( | ||
| isVisible = navigator.showBottomBar(), | ||
| tabs = MainTab.entries.toList(), | ||
| currentTab = navigator.currentTab, | ||
| onTabSelected = navigator::navigate | ||
| ) | ||
| }, |
Comment on lines
+25
to
+27
| include(":domain") | ||
| include(":core") |
Comment on lines
+11
to
+20
| @SerialName("per_page") | ||
| val per_page: Int, | ||
| @SerialName("total") | ||
| val total: Int, | ||
| @SerialName("total_pages") | ||
| val total_pages: Int, | ||
| @SerialName("data") | ||
| val data: List<MockData>, | ||
| @SerialName("support") | ||
| val support: Support, |
There was a problem hiding this comment.
변수명 네이밍에서 카멜케이스가 아닌 스네이크케이스를 따른 이유가 있나욤?
There was a problem hiding this comment.
오호 이 부분은 제가 초기 세팅에 집중하느라 놓쳤네요ㅜㅜ! 카멜케이스로 뒀어야 합니다!
dummy 파일이기 때문에 추후에 지울 예정입니다!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
Screen_Recording_20240629_053015_Terning-Android.mp4
📢 To Reviewers