Feat basic rate limiting #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
like-a-bause
changed the title
like-a-bause
requested review from
FreddyDevelop,
lfleischmann and
bjoern-m
and removed request for
FreddyDevelop and
lfleischmann
FreddyDevelop
requested changes
Jan 24, 2023
Co-authored-by: Frederic Jahn <[email protected]>
Co-authored-by: Frederic Jahn <[email protected]>
Co-authored-by: Frederic Jahn <[email protected]>
Co-authored-by: Frederic Jahn <[email protected]>
Co-authored-by: Frederic Jahn <[email protected]>
Co-authored-by: Frederic Jahn <[email protected]>
Co-authored-by: Frederic Jahn <[email protected]>
…for quickstart with redis.
Co-authored-by: Frederic Jahn <[email protected]>
Co-authored-by: Frederic Jahn <[email protected]>
Co-authored-by: Frederic Jahn <[email protected]>
# Conflicts: # backend/config/config.go # backend/handler/passcode.go # frontend/frontend-sdk/src/lib/client/PasscodeClient.ts # frontend/frontend-sdk/src/lib/client/PasswordClient.ts # frontend/frontend-sdk/tests/lib/client/PasswordClient.spec.ts
FreddyDevelop
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements basic fixed window rate limiting.
Fixes #24 Relates to #213
Implementation
Uses https://github.com/sethvargo/go-limiter
Supports both in-memory and redis backend for scalability.
Now only implemented for: password/init and password/login, with separate stores.
Uses a key combination of user-id and ip.
Limits can be defined for each endpoint separateley.
Tests
Added some tests for the config, which should be expanded for Fields that get Validated.
Added basic functionality test for the rate-limiter library.
Todos
Additional context