Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install) - fix package.json generation during bit install for esm components #9006

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

GiladShoham
Copy link
Member

@GiladShoham GiladShoham commented Jul 7, 2024

Proposed Changes

  • This fixes a use case when you have a component that is compiled to esm with a type:module in its package.json.
    and its env is not part of the workspace.
    Before this fix, the env of the component was not loaded properly resulting in missing type: modules in the package.json.
    If that component is used by another env which is part of the workspace, it will always be loaded during bit component loading. but since the type: module is missing, the component won't be loaded correctly, resulting in the env not loaded.
    This means the workspace is in a deadlock, and the only way to unblock it from any command, is to manually go to the relevant components and add the type: module to the package.json

@GiladShoham GiladShoham changed the title fix(install) - fix package.json generation during bit install for esm envs fix(install) - fix package.json generation during bit install for esm components Jul 7, 2024
@GiladShoham GiladShoham merged commit 3e996e8 into master Jul 8, 2024
11 checks passed
@GiladShoham GiladShoham deleted the fix-install-compile-package-json branch July 8, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants