improvement(bit-lint) - show total instead of names for components with no lint issues

scopes/defender/eslint/eslint.linter.ts

@@ -70,6 +70,7 @@ export class ESLintLinter implements Linter {
         totalFixableWarningCount,
         totalWarningCount,
         componentsResults,
+        isClean,
       } = this.computeComponentResultsWithTotals(results);
 
       return {
@@ -80,6 +81,7 @@ export class ESLintLinter implements Linter {
         totalFixableErrorCount,
         totalFixableWarningCount,
         totalWarningCount,
+        isClean,
         results: componentsResults,
       };
     });
@@ -96,6 +98,7 @@ export class ESLintLinter implements Linter {
       totalComponentsWithFixableErrorCount,
       totalComponentsWithFixableWarningCount,
       totalComponentsWithWarningCount,
+      isClean,
     } = this.computeManyComponentsTotals(results);
 
     return {
@@ -109,6 +112,7 @@ export class ESLintLinter implements Linter {
       totalComponentsWithFixableErrorCount,
       totalComponentsWithFixableWarningCount,
       totalComponentsWithWarningCount,
+      isClean,
       results,
       errors: [],
     };
@@ -175,13 +179,16 @@ export class ESLintLinter implements Linter {
         raw: result,
       };
     });
+    const isClean = totalErrorCount === 0 && totalWarningCount === 0 && totalFatalErrorCount === 0;
+
     return {
       totalErrorCount,
       totalFatalErrorCount,
       totalFixableErrorCount,
       totalFixableWarningCount,
       totalWarningCount,
       componentsResults,
+      isClean,
     };
   }
 
@@ -196,16 +203,19 @@ export class ESLintLinter implements Linter {
     let totalComponentsWithFixableErrorCount = 0;
     let totalComponentsWithFixableWarningCount = 0;
     let totalComponentsWithWarningCount = 0;
+    let isClean = true;
 
     componentsResults.forEach((result) => {
       if (result.totalErrorCount) {
         totalErrorCount += result.totalErrorCount;
         totalComponentsWithErrorCount += 1;
+        isClean = false;
       }
       // @ts-ignore - missing from the @types/eslint lib
       if (result.totalFatalErrorCount) {
         totalFatalErrorCount += result.totalFatalErrorCount;
         totalComponentsWithFatalErrorCount += 1;
+        isClean = false;
       }
       if (result.totalFixableErrorCount) {
         totalFixableErrorCount += result.totalFixableErrorCount;
@@ -218,6 +228,7 @@ export class ESLintLinter implements Linter {
       if (result.totalWarningCount) {
         totalWarningCount += result.totalWarningCount;
         totalComponentsWithWarningCount += 1;
+        isClean = false;
       }
     });
     return {
@@ -232,6 +243,7 @@ export class ESLintLinter implements Linter {
       totalComponentsWithFixableErrorCount,
       totalComponentsWithFixableWarningCount,
       totalComponentsWithWarningCount,
+      isClean,
     };
   }
 

scopes/defender/linter/lint.cmd.ts

@@ -5,7 +5,7 @@ import { ComponentFactory, ComponentID } from '@teambit/component';
 import chalk from 'chalk';
 import { EnvsExecutionResult } from '@teambit/envs';
 import { Workspace } from '@teambit/workspace';
-import { compact, flatten, omit } from 'lodash';
+import { compact, flatten, groupBy, omit } from 'lodash';
 import { LinterMain } from './linter.main.runtime';
 import { ComponentLintResult, LintResults } from './linter';
 import { FixTypes, LinterOptions } from './linter-context';
@@ -63,16 +63,31 @@ export class LintCmd implements Command {
       )}'`
     );
 
-    const componentsOutputs = lintResults.results
+    const groupedByIsClean = groupBy(lintResults.results, (res) => {
+      if (res.isClean !== undefined) {
+        return res.isClean;
+      }
+      // The is clean field was added in a later version of the linter, so if it's not there, we will calculate it
+      // based on the errors/warnings count
+      return res.totalErrorCount + (res.totalFatalErrorCount || 0) + res.totalWarningCount === 0;
+    });
+
+    const dirtyComponentsOutputs = (groupedByIsClean.false || [])
       .map((lintRes) => {
         const compTitle = chalk.bold.cyan(lintRes.componentId.toString({ ignoreVersion: true }));
         const compOutput = lintRes.output;
         return `${compTitle}\n${compOutput}`;
       })
       .join('\n');
 
+    const cleanComponentsCount = groupedByIsClean.true?.length || 0;
+    const cleanComponentsOutput = cleanComponentsCount
+      ? `total of ${chalk.green(cleanComponentsCount.toString())} component(s) has no linting issues`
+      : '';
+
     const summary = this.getSummarySection(data);
-    return { code, data: `${title}\n\n${componentsOutputs}\n\n${summary}` };
+    const finalOutput = compact([title, dirtyComponentsOutputs, cleanComponentsOutput, summary]).join('\n\n');
+    return { code, data: finalOutput };
   }
 
   private getSummarySection(data: JsonLintResultsData) {
@@ -202,6 +217,12 @@ function toJsonLintResults(results: EnvsExecutionResult<LintResults>): JsonLintD
 
     return compact(resultsWithoutComponent);
   });
+
+  const isClean =
+    totalComponentsWithErrorCount === 0 &&
+    totalComponentsWithWarningCount === 0 &&
+    totalComponentsWithFatalErrorCount === 0;
+
   return {
     results: compact(flatten(newResults)),
     totalErrorCount,
@@ -214,6 +235,7 @@ function toJsonLintResults(results: EnvsExecutionResult<LintResults>): JsonLintD
     totalComponentsWithFixableErrorCount,
     totalComponentsWithFixableWarningCount,
     totalComponentsWithWarningCount,
+    isClean,
     errors: results?.errors,
   };
 }

scopes/defender/linter/linter.ts

@@ -34,6 +34,11 @@ export type ComponentLintResult = {
    */
   totalWarningCount: number;
 
+  /**
+   * whether the component is clean (have no issues at all)
+   */
+  isClean: boolean;
+
   /**
    * lint results for each one of the component files
    */
@@ -147,6 +152,11 @@ export type LintResults = {
   totalComponentsWithFixableWarningCount?: number;
   totalComponentsWithWarningCount: number;
 
+  /**
+   * whether all the linted components is clean (have no issues at all)
+   */
+  isClean: boolean;
+
   errors: Error[];
 };