Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix ash_domains config example in Get Started section #678

Closed

Conversation

arcanemachine
Copy link
Contributor

I believe the correction in #676 was slightly off the mark. This little fix adjusts the syntax to the correct value (I think).

@zachdaniel
Copy link
Collaborator

AFAIK the syntax you're replacing works. Perhaps they both work?

config :ash_hq,
  ash_domains: [
    AshHq.Accounts,
    AshHq.Blog,
    AshHq.Docs,
    AshHq.Github,
    AshHq.MailingList,
    AshHq.Discord
  ]

This is what we do in ash_hq for example. Will close for now, but if I'm wrong LMK and we'll reopen :)

@zachdaniel zachdaniel closed this May 13, 2024
@arcanemachine
Copy link
Contributor Author

arcanemachine commented May 13, 2024

Sorry, that's probably just confusion on my part regarding the config syntax. I thought it would write the data to a different section/key.

Note to self: Test both things manually first 😅

EDIT: Yep, both syntaxes work the same.

@arcanemachine arcanemachine deleted the arcanemachine-patch-1 branch May 13, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants