Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(TokenResource)!: rename generated created_at attribute to inserted_at. #430

Closed
wants to merge 1 commit into from

Conversation

jimsynz
Copy link
Collaborator

@jimsynz jimsynz commented Sep 21, 2023

If you are using the token resource this is a breaking change. You will need to generate new migrations using:

mix ash_postgres.generate_migrations --name=rename_created_at_to_inserted_at

It will ask you if you are renaming created_at to inserted_at - answer yes.

This updates and closes #85.

…to `inserted_at`.

If you are using the token resource this is a **breaking change**.  You will need
to generate new migrations using:

    mix ash_postgres.generate_migrations --name=rename_created_at_to_inserted_at

It will ask you if you are renaming `created_at` to `inserted_at` - answer yes.
@jimsynz jimsynz self-assigned this Sep 21, 2023
@jimsynz
Copy link
Collaborator Author

jimsynz commented Sep 21, 2023

Thoughts @zachdaniel? Not sure if it's worth the major release just to change the name of an attribute.

@zachdaniel
Copy link
Collaborator

IMO it is definitely not worth it. We can make it configurable if some people need that.

@jimsynz
Copy link
Collaborator Author

jimsynz commented Sep 21, 2023

👍

@jimsynz jimsynz closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants