Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: add metadata declarations to actions that have a token #164

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

zachdaniel
Copy link
Collaborator

@zachdaniel zachdaniel commented Jan 28, 2023

Nothing in ash core uses these static metadata declarations, but they are used by API extensions to know that they should potentially expose action-specific metadata. Currently only AshGraphql will use this information

… metadata

Nothing in ash core uses these static metadata declarations, but they are used
by API extensions to know that they should potentially expose action-specific
metadata. Currently only AshGraphql will use this information
@zachdaniel zachdaniel changed the title improvement: add metadata declarations to actions that have a token improvement: add metadata declarations to actions that have a token Jan 28, 2023
@zachdaniel
Copy link
Collaborator Author

zachdaniel commented Jan 28, 2023

The reason for this is because if a user wants to sign in over a graphql and then retrieve the token on the client, ash_graphql needs a way to know to add that to the type. The original discussion was on discord and the tracking issue for the core change is here: ash-project/ash#494

@jimsynz
Copy link
Collaborator

jimsynz commented Jan 30, 2023

It needs to go anywhere that GenerateTokenChange is used - that means in OAuth also.

@zachdaniel
Copy link
Collaborator Author

But those actions you define yourself, right? So you'd add the metadata yourself if you wanted to. Its unlikely that people would hook the oauth actions up to an api extension, but they potentially could.

@jimsynz
Copy link
Collaborator

jimsynz commented Jan 30, 2023

But those actions you define yourself, right? So you'd add the metadata yourself if you wanted to. Its unlikely that people would hook the oauth actions up to an api extension, but they potentially could.

DOH!

Copy link
Collaborator

@jimsynz jimsynz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big brain

@zachdaniel zachdaniel merged commit bd6e57b into main Jan 30, 2023
@zachdaniel zachdaniel deleted the add-metadata branch January 30, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants