Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix signing_secret examples #138

Closed
wants to merge 1 commit into from
Closed

Fix signing_secret examples #138

wants to merge 1 commit into from

Conversation

zimt28
Copy link
Contributor

@zimt28 zimt28 commented Jan 16, 2023

No description provided.

jimsynz
jimsynz reviewed Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@jimsynz jimsynz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I missing something? Application.fetch_env/2 does return an ok tuple.

@zimt28
Copy link
Contributor Author

zimt28 commented Jan 16, 2023

@jimsynz You aren't. I used Application.fetch_env!/2 and had to return the tuple manually, but fetch_env/2 already does that of course.. Shouldn't have worked until 3am :)

@zimt28 zimt28 closed this Jan 16, 2023
@jimsynz
Copy link
Collaborator

jimsynz commented Jan 16, 2023

All good mate. Get some sleep 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimsynz jimsynz jimsynz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zimt28 @jimsynz