improvement: Set Ash actor and tenant when executing internal plugs. #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think its a good idea to use the context based approach to setting actor/tenant really. I advise against it in the docs generally, and things can get weird (i.e if somehow code happens in a different process, the actor isn't automatically carried over) |
Okie dokie. I'll do the slightly more longwinded method. |
jimsynz
force-pushed
the
improvement/use-actor-tenant-in-conn
branch
from
8c9f27f
to
3c2c957
Compare
|
@zachdaniel updated. |
zachdaniel
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #114.