Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Import excel relative bugs #676

Merged
merged 2 commits into from
Jun 26, 2024
Merged

fix: Import excel relative bugs #676

merged 2 commits into from
Jun 26, 2024

Conversation

caoxing9
Copy link
Contributor

fix: same dbFieldName error
fix: guarantee memory safety when import excel too much records using chunk

@caoxing9 caoxing9 requested a review from tea-artist June 26, 2024 02:59
@coveralls
Copy link
Collaborator

coveralls commented Jun 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9672838376

Details

  • 27 of 31 (87.1%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+63.8%) to 82.499%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/import/open-api/import.class.ts 12 14 85.71%
apps/nestjs-backend/src/features/table/open-api/table-open-api.service.ts 15 17 88.24%
Totals Coverage Status
Change from base Build 9661986888: 63.8%
Covered Lines: 26148
Relevant Lines: 31695
💛 - Coveralls

@caoxing9 caoxing9 merged commit 13b4463 into develop Jun 26, 2024
6 checks passed
@caoxing9 caoxing9 deleted the fix/import-repeat-dbfieldname branch June 26, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tea-artist tea-artist tea-artist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@caoxing9 @coveralls @tea-artist