Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Sort option #47

Merged
merged 10 commits into from
May 5, 2019
Merged

Adding Sort option #47

merged 10 commits into from
May 5, 2019

Conversation

sylvain-d
Copy link
Contributor

Answer to issue #46

Add a new property to Search function to support sort.
leboncoin offers two sort option, by date or by price, ascending or descending.

With :
.setSort({sort_by:"date",sort_order:"asc"})
add at the end of bodyParams
"sort_by":"date","sort_order":"asc"}

Properties sort_by and sort_order are set to null if Search.sort is null or the properties are wrong.
Even null the request works.

Comment on the use of Area instead of Department, Region, Location.
To search around a lat/long position
Add comment for the use of .setArea
@tdurieux
Copy link
Owner

tdurieux commented May 4, 2019

There is a conflict with the master can you fix it?

Thank you

@sylvain-d
Copy link
Contributor Author

Resolved.
I rewrite my comment in README.md

Should be fine

@sylvain-d
Copy link
Contributor Author

:( forget to modify the tests.
Going back to code

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 61.814% when pulling 8ea040d on sylvain-d:master into 52cf54c on tdurieux:master.

@tdurieux tdurieux merged commit fb157e4 into tdurieux:master May 5, 2019
@tdurieux
Copy link
Owner

tdurieux commented May 5, 2019

Thanks a lot for your PR, I will publish a new release on npm

@sylvain-d
Copy link
Contributor Author

Le travail de base est un vrai plus pour moi.
C'est avec plaisir.

@mishka81
Copy link

mishka81 commented May 5, 2019

thats' nice, thanks for your reactivity !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants